qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job f


From: Eric Blake
Subject: Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files
Date: Fri, 8 Jun 2018 10:00:32 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/08/2018 09:59 AM, Eric Blake wrote:
On 06/07/2018 05:31 PM, Ross Zwisler wrote:
With a fully built QEMU I currently see the following with "git status":

   Untracked files:
     (use "git add <file>..." to include in what will be committed)

       qapi/qapi-commands-job.c
       qapi/qapi-commands-job.h
       qapi/qapi-events-job.c
       qapi/qapi-events-job.h
       qapi/qapi-types-job.c
       qapi/qapi-types-job.h
       qapi/qapi-visit-job.c
       qapi/qapi-visit-job.h

These are all generated files.  Ignore them.

Signed-off-by: Ross Zwisler <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Eric Blake <address@hidden>
Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json")

You're the third to post this:

https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg07280.html
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01624.html

Also, when sending a series, it's best to include a 0/5 cover letter (the automated CI tooling handles that better, among other reasons). You can use 'git config' to automatically send a cover letter for any patch series > 1. For more tips, https://wiki.qemu.org/Contribute/SubmitAPatch

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]