[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix defi
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix definitions |
Date: |
Sun, 10 Jun 2018 22:14:28 -0300 |
It eases code review, unit is explicit.
Patch generated using:
$ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
and modified manually.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
hw/misc/ivshmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 16f03701b7..9a9f990867 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -17,6 +17,7 @@
* GNU GPL, version 2 or (at your option) any later version.
*/
#include "qemu/osdep.h"
+#include "qemu/units.h"
#include "qapi/error.h"
#include "qemu/cutils.h"
#include "hw/hw.h"
@@ -1302,7 +1303,7 @@ static void ivshmem_realize(PCIDevice *dev, Error **errp)
}
if (s->sizearg == NULL) {
- s->legacy_size = 4 << 20; /* 4 MB default */
+ s->legacy_size = 4 * MiB; /* 4 MB default */
} else {
int ret;
uint64_t size;
--
2.17.1
- [Qemu-devel] [PATCH v4 02/40] vdi: Use definitions from "qemu/units.h", (continued)
- [Qemu-devel] [PATCH v4 02/40] vdi: Use definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 03/40] x86/cpu: Use definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 05/40] hw: Use IEC binary prefix definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix definitions,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v4 08/40] hw/ipack: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 09/40] hw/scsi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 10/40] hw/smbios: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Richard Henderson, 2018/06/12
- Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Eric Blake, 2018/06/12
- Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Richard Henderson, 2018/06/12
- Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Eric Blake, 2018/06/13
- Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Richard Henderson, 2018/06/13
- Re: [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/13