[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig |
Date: |
Mon, 11 Jun 2018 18:38:30 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
* Markus Armbruster (address@hidden) wrote:
> "Dr. David Alan Gilbert (git)" <address@hidden> writes:
>
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Don't show the commands that aren't available.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > Reviewed-by: Peter Xu <address@hidden>
> > Reviewed-by: Igor Mammedov <address@hidden>
> > ---
> > monitor.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index 31c8f5dc88..c369b392db 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -3951,12 +3951,17 @@ static void
> > monitor_find_completion_by_table(Monitor *mon,
> > cmdname = args[0];
> > readline_set_completion_index(mon->rs, strlen(cmdname));
> > for (cmd = cmd_table; cmd->name != NULL; cmd++) {
> > - cmd_completion(mon, cmdname, cmd->name);
> > + if (!runstate_check(RUN_STATE_PRECONFIG) ||
> > + cmd_can_preconfig(cmd)) {
> > + cmd_completion(mon, cmdname, cmd->name);
> > + }
> > }
> > } else {
> > /* find the command */
> > for (cmd = cmd_table; cmd->name != NULL; cmd++) {
> > - if (compare_cmd(args[0], cmd->name)) {
> > + if (compare_cmd(args[0], cmd->name) &&
> > + (!runstate_check(RUN_STATE_PRECONFIG) ||
> > + cmd_can_preconfig(cmd))) {
> > break;
> > }
> > }
>
> Hmm, I keep seeing
>
> !runstate_check(RUN_STATE_PRECONFIG) || cmd_can_preconfig(cmd)
>
> Would a helper be worthwhile? cmd_available(cmd)?
Yes, but I want to leave that change until I add the next flag (for OOB
some time) so I know how to generalise it; I'm not sure what it'll need
yet.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v3 6/7] hmp: add exit_preconfig, (continued)
[Qemu-devel] [PATCH v3 3/7] hmp: Restrict auto-complete in preconfig, Dr. David Alan Gilbert (git), 2018/06/08
[Qemu-devel] [PATCH v3 7/7] hmp: Allow HMP in preconfig state again, Dr. David Alan Gilbert (git), 2018/06/08
Re: [Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode, Markus Armbruster, 2018/06/11