[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name |
Date: |
Mon, 11 Jun 2018 11:49:44 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/11/2018 10:37 AM, Eduardo Habkost wrote:
> RFC NOTE: Paolo, Richard, as far as I can see, there's no point
> in enabling OSPKE in user-mode QEMU. Do you confirm that?
>
> OSPKE is not a static feature flag: it changes dynamically at
> runtime depending on CR4, and it was never configurable: KVM
> never returned OSPKE on GET_SUPPORTED_CPUID, and on TCG enables
> it automatically if CR4_PKE_MASK is set.
>
> Remove OSPKE from the feature name array so users don't try to
> configure it manually.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> target/i386/cpu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/11
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name,
Richard Henderson <=
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/13
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/13
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/13