[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 09/11] pc-dimm: remove pc_dimm_get_vmstate_me
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v1 09/11] pc-dimm: remove pc_dimm_get_vmstate_memory_region() |
Date: |
Tue, 12 Jun 2018 11:29:05 +1000 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Mon, Jun 11, 2018 at 02:16:53PM +0200, David Hildenbrand wrote:
> We can reuse pc_dimm_get_memory_region() now, as both functions are
> (besides the assert which is also correct), equal.
>
> Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/mem/pc-dimm.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 9a0da5d441..bc79dd04d8 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -219,11 +219,6 @@ static MemoryRegion
> *pc_dimm_get_memory_region(PCDIMMDevice *dimm)
> return host_memory_backend_get_memory(dimm->hostmem);
> }
>
> -static MemoryRegion *pc_dimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
> -{
> - return host_memory_backend_get_memory(dimm->hostmem);
> -}
> -
> static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)
> {
> const PCDIMMDevice *dimm = PC_DIMM(md);
> @@ -282,7 +277,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void
> *data)
> dc->desc = "DIMM memory module";
>
> ddc->get_memory_region = pc_dimm_get_memory_region;
> - ddc->get_vmstate_memory_region = pc_dimm_get_vmstate_memory_region;
> + ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
>
> mdc->get_addr = pc_dimm_md_get_addr;
> /* for a dimm plugged_size == region_size */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, (continued)
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, David Gibson, 2018/06/11
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, Igor Mammedov, 2018/06/13
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, David Hildenbrand, 2018/06/13
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, David Hildenbrand, 2018/06/13
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, Igor Mammedov, 2018/06/14
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, David Hildenbrand, 2018/06/14
- Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail, Igor Mammedov, 2018/06/15
[Qemu-devel] [PATCH v1 08/11] pc-dimm: get_memory_region() will never return a NULL pointer, David Hildenbrand, 2018/06/11
[Qemu-devel] [PATCH v1 09/11] pc-dimm: remove pc_dimm_get_vmstate_memory_region(), David Hildenbrand, 2018/06/11
- Re: [Qemu-devel] [PATCH v1 09/11] pc-dimm: remove pc_dimm_get_vmstate_memory_region(),
David Gibson <=
[Qemu-devel] [PATCH v1 11/11] pc-dimm: assign and verify the "slot" property during pre_plug, David Hildenbrand, 2018/06/11
[Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug(), David Hildenbrand, 2018/06/11
Re: [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups, Igor Mammedov, 2018/06/13