Re: [Qemu-devel] [PATCH v4 1/1] s390x/ipl: Try to detect Linux vs non Linux for initial IPL PSW

[Cornelia Huck]

On Tue, 12 Jun 2018 14:59:33 +0200
Christian Borntraeger <address@hidden> wrote:

> Right now the IPL device always starts from address 0x10000 (the usual
> Linux entry point). To run other guests (e.g. test programs) it is
> useful to use the IPL PSW from address 0. We can use the Linux magic
> at 0x10008 to decide.
> 
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
> v3->v4:
>       - iplpsw-> ipl_psw
>       - move check for load failures into the non-elf case
>       - change comment about ipl psw
> v2->v3:
>       - check for iplpsw to avoid assert on file errors
>       - use 4 bytes at 4 instead of 8 bytes at 0
> v1->v2:
>       - use LINUX_MAGIC_ADDR define
>       - use assert for valid iplpsw pointer
>       - add endianess conversion
>  hw/s390x/ipl.c | 27 ++++++++++++++++++++++-----
>  1 file changed, 22 insertions(+), 5 deletions(-)

Looks good to me. Will queue after getting some R-bs for this version.