Re: [Qemu-devel] [PATCH 1/3] bswap: Add new stn_*_p() and ldn_*_p() memory access functions

[Richard Henderson]

On 06/11/2018 07:52 AM, Peter Maydell wrote:
> On 11 June 2018 at 18:10, Peter Maydell <address@hidden> wrote:
>> There's a common pattern in QEMU where a function needs to perform
>> a data load or store of an N byte integer in a particular endianness.
>> At the moment this is handled by doing a switch() on the size and
>> calling the appropriate ld*_p or st*_p function for each size.
>>
>> Provide a new family of functions ldn_*_p() and stn_*_p() which
>> take the size as an argument and do the switch() themselves.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>>  include/exec/cpu-all.h      |  4 +++
>>  include/qemu/bswap.h        | 52 +++++++++++++++++++++++++++++++++++++
>>  docs/devel/loads-stores.rst | 15 +++++++++++
>>  3 files changed, 71 insertions(+)
>>
>> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
>> index a635f532f97..07ec3808342 100644
>> --- a/include/exec/cpu-all.h
>> +++ b/include/exec/cpu-all.h
>> @@ -133,6 +133,8 @@ static inline void tswap64s(uint64_t *s)
>>  #define stq_p(p, v) stq_be_p(p, v)
>>  #define stfl_p(p, v) stfl_be_p(p, v)
>>  #define stfq_p(p, v) stfq_be_p(p, v)
>> +#define ldn_p(p, sz ldn_be_p(p, sz)
> 
> Silly typo here -- missing ')'.

Reviewed-by: Richard Henderson <address@hidden>


r~