Re: [Qemu-devel] [PULL 50/69] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO

[Philippe Mathieu-Daudé]

On 06/13/2018 02:17 PM, Philippe Mathieu-Daudé wrote:
> On 06/13/2018 01:35 PM, Philippe Mathieu-Daudé wrote:
>> On 06/13/2018 01:21 PM, Paolo Bonzini wrote:
>>> On 01/06/2018 20:51, Emilio G. Cota wrote:
>>>> On Tue, Mar 13, 2018 at 23:47:00 +0100, Paolo Bonzini wrote:
>>>>> From: Philippe Mathieu-Daudé <address@hidden>
>>>>>
>>>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>>>> Message-Id: <address@hidden>
>>>>> Signed-off-by: Paolo Bonzini <address@hidden>
>>>>> ---
>>>>>  default-configs/alpha-softmmu.mak |  3 +++
>>>>>  hw/alpha/dp264.c                  | 10 ++++------
>>>>>  2 files changed, 7 insertions(+), 6 deletions(-)
>>>>
>>>> This commit breaks alpha-softmmu bootup for me. I get no console
>>>> output whatsoever -- not even the green "Hello" when invoking
>>>> the alpha-softmmu binary with no arguments.
>>>>
>>>> Did anybody else notice this?
>>>
>>> Philippe, are you going to take a look?  I tested 2.12 and I get the
>>
>> Sure. Sorry I didn't notice earlier, my mail-filter demotes subject with
>> PULL :/
>>
>>> same result as latest mainline: nothing on the VGA and
>>>
>>> PCI: 00:00:0 class 0300 id 1013:00b8
>>> PCI:   region 0: 10000000
>>> PCI:   region 1: 12000000
>>> PCI: 00:01:0 class 0200 id 8086:100e
>>> PCI:   region 0: 12020000
>>> PCI:   region 1: 0000c000
>>> PCI: 00:02:0 class 0101 id 1095:0646
>>> PCI:   region 0: 0000c040
>>> PCI:   region 1: 0000c048
>>> PCI:   region 3: 0000c04c
>>>
>>> on the serial console, respectively for VGA/network/IDE.
> 
> Creating the Super I/O _before_ the VGA setup fixes this issue...
> 
> I suppose the problem is some ISA global variable? I'll keep digging.

Mark Cave-Ayland figured out yesterday than some VGA I/O space was
shadowed by the parallel device:

    ..
    00000801fc0002f8-00000801fc0002ff (prio 0, i/o): serial
    00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
    00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
    00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
                                  ^^^                ^^^^^^^^
    00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
                 ^^^
    00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
    00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
    00000801fc0003f1-00000801fc0003f5 (prio 0, i/o): fdc
    00000801fc0003f7-00000801fc0003f7 (prio 0, i/o): fdc

> 
> -- >8 --
> diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
> @@ -83,6 +83,12 @@ static void clipper_init(MachineState *machine)
> 
>      i8254_pit_init(isa_bus, 0x40, 0, NULL);
> 
> +    /* 2 82C37 (dma) */
> +    isa_create_simple(isa_bus, "i82374");
> +
> +    /* Super I/O */
> +    isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO);
> +
>      /* VGA setup.  Don't bother loading the bios.  */
>      pci_vga_init(pci_bus);
> 
> @@ -91,12 +97,6 @@ static void clipper_init(MachineState *machine)
>          pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
>      }
> 
> -    /* 2 82C37 (dma) */
> -    isa_create_simple(isa_bus, "i82374");
> -
> -    /* Super I/O */
> -    isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO);
> -
>      /* IDE disk setup.  */
>      {
>          DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
>