[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate |
Date: |
Fri, 15 Jun 2018 12:30:54 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
* address@hidden (address@hidden) wrote:
> From: Xiao Guangrong <address@hidden>
>
> Sync up xbzrle_cache_miss_prev only after migration iteration goes
> forward
>
> Signed-off-by: Xiao Guangrong <address@hidden>
This patch (not the whole set) queued
> ---
> migration/ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index dbf24d8c87..dd1283dd45 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1189,9 +1189,9 @@ static void migration_bitmap_sync(RAMState *rs)
> (double)(xbzrle_counters.cache_miss -
> rs->xbzrle_cache_miss_prev) /
> (rs->iterations - rs->iterations_prev);
> + rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss;
> }
> rs->iterations_prev = rs->iterations;
> - rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss;
> }
>
> /* reset period counters */
> --
> 2.14.4
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 02/12] migration: fix counting normal page for compression, (continued)
[Qemu-devel] [PATCH 03/12] migration: fix counting xbzrle cache_miss_rate, guangrong . xiao, 2018/06/04
[Qemu-devel] [PATCH 04/12] migration: introduce migration_update_rates, guangrong . xiao, 2018/06/04
[Qemu-devel] [PATCH 05/12] migration: show the statistics of compression, guangrong . xiao, 2018/06/04
[Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression, guangrong . xiao, 2018/06/04