|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v3 1/2] kvm: support -dedicated cpu-pm=on|off |
Date: | Tue, 19 Jun 2018 17:07:46 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/19/2018 10:17 AM, Paolo Bonzini wrote:
On 16/06/2018 00:29, Michael S. Tsirkin wrote:+static QemuOptsList qemu_dedicated_opts = {+ .name = "dedicated", + .head = QTAILQ_HEAD_INITIALIZER(qemu_dedicated_opts.head), + .desc = { + { + .name = "mem-lock", + .type = QEMU_OPT_BOOL, + }, + { + .name = "cpu-pm", + .type = QEMU_OPT_BOOL, + }, + { /* end of list */ } + }, +}; +Let the bikeshedding begin! 1) Should we deprecate -realtime? 2) Maybe -hostresource?
What further things might we add in the future?-dedicated sounds wrong (it is an adjective, while most of our options are nouns - thing -machine, -drive, -object, ...)
-hostresource at least sounds like a noun, but is long to type. But at least '-hostresource cpu-pm=on' reads reasonably well.
About the only other noun I could think of would be '-feature cpu-pm=on'. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |