[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED |
Date: |
Wed, 20 Jun 2018 11:04:04 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Tue, Jun 19, 2018 at 03:55:12PM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
>
> > On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote:
> >
> > [...]
> >
> >> Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27)
> >> Suggested-by: Markus Armbruster <address@hidden>
> >> Signed-off-by: Peter Xu <address@hidden>
> >>
> >> Signed-off-by: Peter Xu <address@hidden>
> >
> > I am pretty sure this time that this 2nd line is not there in my local
> > tree. :)
> >
> > I think it's a git-format-patch bug, otherwise I must have misused it
> > for a long time. Instead of figuring this out and repost again, I'll
> > see how far the rest of the series can go.
>
> Do you use git-format-patch -s, or have format.signOff set in
> .git/config or ~/.gitconfig?
Ah it's in my ~/.gitconfig! Removing that fixes the issue.
Though I'm still not sure why the problem doesn't happen with other
patches. After all, due to the line wrapping mess I still prefer to
drop that chunk in commit message directly.
Regards,
--
Peter Xu
[Qemu-devel] [PATCH v4 4/7] tests: iotests: drop some stderr line, Peter Xu, 2018/06/19
[Qemu-devel] [PATCH v4 5/7] docs: mention shared state protect for OOB, Peter Xu, 2018/06/19