Re: [Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules

[Michael S. Tsirkin]

On Wed, Jun 20, 2018 at 05:57:56PM +0300, Roman Kagan wrote:
> On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote:
> > This short series fixes a flaw identified by coverity which broke the
> > handling of multiboot modules.
> 
> This flaw also makes QEMU segfault when running kvm-unit-tests, and the
> series fixes it.
> 
> So
> 
> Tested-by: Roman Kagan <address@hidden>
> 
> Wondering if anyone else runs kvm-unit-tests with QEMU master,
> Roman.

It might be a good idea to make it a submodule, and
use it for unit tests. I'll take a look.

> > 
> > Daniel P. Berrangé (3):
> >   i386: fix regression parsing multiboot initrd modules
> >   i386: only parse the initrd_filename once for multiboot modules
> >   opts: remove redundant check for NULL parameter
> > 
> >  hw/i386/multiboot.c | 35 ++++++++++++++++-------------------
> >  util/qemu-option.c  |  8 +++-----
> >  2 files changed, 19 insertions(+), 24 deletions(-)
> > 
> > -- 
> > 2.17.0
> > 
> >