|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH] nbd/server: Reject 0-length block status request |
Date: | Thu, 21 Jun 2018 09:27:50 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/21/2018 07:52 AM, Vladimir Sementsov-Ogievskiy wrote:
21.06.2018 15:49, Eric Blake wrote:The NBD spec says that behavior is unspecified if the client requests 0 length for block status; but since the structured reply is documenting as returning a non-zero length, it's easier to just diagnose this with an EINVAL error than to figure out what to return. CC: address@hidden Signed-off-by: Eric Blake <address@hidden>Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Thanks; added to my NBD queue. Doing this makes it easier to add the assertion necessary to shut up gcc warning about an uninitialized variable in the other patches ready to pull.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |