Re: [Qemu-devel] [PULL v2 00/57] add check-tcg and associated machinery

[Philippe Mathieu-Daudé]

On 06/21/2018 01:04 PM, Philippe Mathieu-Daudé wrote:
> On 06/21/2018 12:12 PM, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé <address@hidden> writes:
>>
>>> Hi Alex,
>>>
>>> On 06/21/2018 11:48 AM, Alex Bennée wrote:
>>>>
>>>> Peter Maydell <address@hidden> writes:
>>>>
>>>>> On 21 June 2018 at 07:25, Alex Bennée <address@hidden> wrote:
>>>>>> The following changes since commit 
>>>>>> 46012db666990ff2eed1d3dc199ab8006439a93b:
>>>>>>
>>>>>>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into 
>>>>>> staging (2018-06-20 09:51:30 +0100)
>>>>>>
>>>>>> are available in the Git repository at:
>>>>>>
>>>>>>   https://github.com/stsquad/qemu.git 
>>>>>> tags/pull-tcg-testing-revivial-210618-2
>>>>>>
>>>>>> for you to fetch changes up to 65b26da485540ffcc1c46c9a0898f01912ee6b7a:
>>>>>>
>>>>>>   .travis.yml: add check-tcg test (2018-06-20 22:13:39 +0100)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>> Add check-tcg machinary
>>>>>>
>>>>>> This restores the ability to run TCG smoke tests by using our docker
>>>>>> infrastructure to support cross building simple tests. It represents
>>>>>> the first step to making better cross-architecture testing available
>>>>>> straight from the source tree ;-)
>>>>>>
>>>>>> v2
>>>>>>   - fix quoting of target_compiler
>>>>>>   - make docker.py Py3 safe
>>>>>>   - tweak .travis.yml recipe
>>>>>>   - don't probe docker when HAVE_USER_DOCKER not set
>>>>>
>>>>> Weird build failure for linux/x86:
>>>>>
>>>>> make: Entering directory 
>>>>> '/home/petmay01/linaro/qemu-for-merges/build/alldbg'
> 
> This looks like an out-of-tree build.
> I suppose SRC_PATH=.../qemu-for-merges/
> 
>>>>> Makefile:90: rules.mak: No such file or directory
>>>>> Makefile:439: tests/Makefile.include: No such file or directory
>>>>> cat: VERSION: No such file or directory
>>>>> Makefile:1056: tests/docker/Makefile.include: No such file or directory
>>>>> Makefile:1057: tests/vm/Makefile.include: No such file or directory
>>>>> make: Leaving directory 
>>>>> '/home/petmay01/linaro/qemu-for-merges/build/alldbg'
>>>>> make: *** No rule to make target 'tests/vm/Makefile.include'. Stop.
>>>>>
>>>>> like it's failed to figure out the source directory.
>>>>>
>>>>> This is my '--cc=ccache gcc' '--enable-debug' '--python=python3'
>>>>> build, and it's also the one I do a 'make clean' on -- perhaps
>>>>> build from clean has broken?
>>>>
>>>> Hmm I can't reproduce this. I've built a fresh 16.04 server image with
>>>> and with:
>>>>
>>>>   # Configured with: './configure' '--cc=ccache gcc' '--enable-debug' 
>>>> '--python=python3'
>>>>
>>>> both:
>>>>   make
>>>>
>>>> and:
>>>>   make check-tcg
>>>>
>>>> Work for me :-/
>>>
>>> Did you try rebuilding after a 'make clean'?
>>
>> Yep, both make clean, configure, make and make clean, make
> 
> I can not reproduce neither using out-of-tree build with
> ../../configure '--cc=ccache gcc' '--enable-debug' '--python=python3'
> 
> I'll now test:
> 
> $ git checkout master

$ make

> $ make clean
> $ git checkout pull-tcg-testing-revivial-210618-2
> $ make check-tcg

This worked ('clean' in previous branch).

I also tested 'clean' in new branch:

$ git checkout master
$ make
$ git checkout pull-tcg-testing-revivial-210618-2
$ make clean
$ make check-tcg

Eventually the previous branch was not 'master' but the last pull
request Peter tested, and the problem would be there or between this
branch and yours.