Re: [Qemu-devel] [RFC PATCH] exec: Move hw_error() to the CPU namespace

[Peter Maydell]

On 22 June 2018 at 14:46, Philippe Mathieu-Daudé <address@hidden> wrote:
> hw_error() is only meant for CPU errors (since it dumps the CPU state).

I would disagree. hw_error() dumps the state of every CPU. The
corresponding function for CPU errors is cpu_abort(), which
dumps only the state of the relevant CPU. It is used pretty
much only by device models, not by cpu models.

In any case, this is one of those functions that's a left
over from a more innocent time when causing QEMU to bomb out
with a screenful of hexdump was a reasonable response to the
guest doing something weird or unsupported. In an ideal world
we'd gradually get rid of the existing callsites...

thanks
-- PMM