[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] block/file-posix: reconfigure aio on iot
|
From: |
Nishanth Aravamudan |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] block/file-posix: reconfigure aio on iothread start |
|
Date: |
Fri, 22 Jun 2018 10:12:24 -0700 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On 22.06.2018 [11:02:06 +0200], Kevin Wolf wrote:
> Am 22.06.2018 um 04:25 hat Fam Zheng geschrieben:
> > On Thu, 06/21 15:21, Nishanth Aravamudan wrote:
> > > When the AioContext changes, we need to associate a LinuxAioState with
> > > the new AioContext. Use the bdrv_attach_aio_context callback and call
> > > the new aio_setup_linux_aio(), which will allocate a new AioContext if
> > > needed, and return errors on failures. If it fails for any reason,
> > > fallback to threaded AIO with an error message, as the device is already
> > > in-use by the guest.
> > >
> > > Signed-off-by: Nishanth Aravamudan <address@hidden>
> > > ---
> > > Note this patch didn't exist in v2, but is a result of feedback to that
> > > posting.
> >
> > This should be squashed into patch 1, no?
>
> Yes, without it, patch 1 is incorrect. Specifically, at least the
> assertion in aio_get_linux_aio() won't hold true without it.
Yes, you are right! Sorry about that. I'll send a v4 today.
-Nish