[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage |
Date: |
Fri, 22 Jun 2018 10:53:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/22/2018 10:45 AM, Emilio G. Cota wrote:
> Fix the --disable-tcg breakage introduced by tb_lock's removal by
> relying on the fact that tcg_enabled() is set to 0 at
> compile-time under --disable-tcg.
>
> While at it, add further asserts to fix builds that enable both
> --disable-tcg and --enable-debug, which were broken even before
> tb_lock's removal.
>
> Tested to build x86_64-softmmu and i386-softmmu targets.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> accel/stubs/tcg-stub.c | 4 ----
> cpus.c | 4 ++++
> exec.c | 3 +++
> 3 files changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
Peter, I'm assuming you'll take this directly to master as a build fix.
r~