[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] hw/block/fdc: Replace error_setg(&error_
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] hw/block/fdc: Replace error_setg(&error_abort) by assert() |
|
Date: |
Mon, 25 Jun 2018 13:13:38 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/25/2018 12:57 PM, Philippe Mathieu-Daudé wrote:
> Use assert() instead of error_setg(&error_abort),
> as suggested by the "qapi/error.h" documentation:
>
> Please don't error_setg(&error_fatal, ...), use error_report() and
> exit(), because that's more obvious.
> Likewise, don't error_setg(&error_abort, ...), use assert().
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Acked-by: John Snow <address@hidden>
AIUI this series is to be merged by someone else currently, right?
Nothing needed on my part?