[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP comma
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command |
Date: |
Wed, 27 Jun 2018 17:34:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 26/06/2018 22:51, Eric Blake wrote:
> On 06/26/2018 10:40 AM, Paolo Bonzini wrote:
>> This command lets you query the connection status of each
>> pr-manager-helper
>> object.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>
>> +++ b/qapi/block.json
>> @@ -77,6 +77,33 @@
>> { 'struct': 'BlockdevSnapshotInternal',
>> 'data': { 'device': 'str', 'name': 'str' } }
>> +##
>> +# @PRManagerInfo:
>> +#
>> +# Information about a persistent reservation manager
>> +#
>> +# @id: the identifier of the persistent reservation manager
>> +#
>> +# @is-connected: whether the persistent reservation manager is
>> connected to
>> +# the underlying storage or helper
>> +#
>> +# Since: 3.0
>> +##
>> +{ 'struct': 'PRManagerInfo',
>> + 'data': {'id': 'str', 'is-connected': 'bool'} }
>
> Bike-shedding: I think 'connected' is a reasonable (and shorter) name
> for this member
Sounds good.
>> +
>> +##
>> +# @query-pr-managers:
>> +#
>> +# Returns a list of information about each persistent reservation
>> manager.
>> +#
>> +# Returns: a list of @PRManagerInfo for each persistent reservation
>> manager
>> +#
>> +# Since: 3.0
>> +##
>> +{ 'command': 'query-pr-managers', 'returns': ['PRManagerInfo'] }
>> +
>
> As a query command, does it make sense to consider whether this command
> could be provided during preconfig?
Yes, definitely.
Paolo
- [Qemu-devel] [PATCH 0/5] pr-manager/qemu-pr-helper patches for QEMU 3.0, Paolo Bonzini, 2018/06/26
- [Qemu-devel] [PATCH 1/5] pr-helper: fix --socket-path default in help, Paolo Bonzini, 2018/06/26
- [Qemu-devel] [PATCH 3/5] pr-manager-helper: avoid SIGSEGV when writing to the socket fail, Paolo Bonzini, 2018/06/26
- [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command, Paolo Bonzini, 2018/06/26
- [Qemu-devel] [PATCH 2/5] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN, Paolo Bonzini, 2018/06/26
- [Qemu-devel] [PATCH 5/5] pr-manager-helper: report event on connection/disconnection, Paolo Bonzini, 2018/06/26