[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 19/22] target/openrisc: Add print_insn_or1k
From: |
Stafford Horne |
Subject: |
Re: [Qemu-devel] [PATCH v2 19/22] target/openrisc: Add print_insn_or1k |
Date: |
Thu, 28 Jun 2018 08:17:14 +0900 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Wed, Jun 27, 2018 at 09:15:09AM -0700, Richard Henderson wrote:
> On 06/27/2018 09:03 AM, Philippe Mathieu-Daudé wrote:
> >> +INSN(nop, "")
> >
> > The nop previously displayed 'k', I suppose a left-over from sys/trap.
>
> Yes, real nop has no argument.
Just for some history here, in case others are interested. The nop in openrisc
does have an argument, but it is not used in real hardware. It is a
hack/shortcut used by the old simulator to trigger debugging operations. Its
used a lot in a few tests and even in the kernel, but I dont think we want to
carry it in QEMU. I am happy to get rid of it.
https://github.com/openrisc/or1ksim/blob/f75787f390cbd543b8ae49a2670ff338d6e9326a/cpu/or32/insnset.c#L766-L825
Also in: cpu/or1k/spr-defs.h
#define NOP_NOP 0x0000 /* Normal nop instruction */
#define NOP_EXIT 0x0001 /* End of simulation */
#define NOP_REPORT 0x0002 /* Simple report */
/*#define NOP_PRINTF 0x0003 Simprintf instruction (obsolete)*/
#define NOP_PUTC 0x0004 /* JPB: Simputc instruction */
#define NOP_CNT_RESET 0x0005 /* Reset statistics counters */
...
-Stafford
- [Qemu-devel] [PATCH v2 15/22] target/openrisc: Stub out handle_mmu_fault for softmmu, (continued)
- [Qemu-devel] [PATCH v2 15/22] target/openrisc: Stub out handle_mmu_fault for softmmu, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 18/22] target/openrisc: Reorg tlb lookup, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 20/22] target/openrisc: Add support in scripts/qemu-binfmt-conf.sh, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 22/22] linux-user: Fix struct sigaltstack for openrisc, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 21/22] linux-user: Implement signals for openrisc, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 19/22] target/openrisc: Add print_insn_or1k, Richard Henderson, 2018/06/18
- Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements, no-reply, 2018/06/18
- Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements, Stafford Horne, 2018/06/21