Re: [Qemu-devel] [PATCH 5/6] target/arm: Add ID_ISAR6

[Richard Henderson]

On 06/28/2018 05:57 PM, Philippe Mathieu-Daudé wrote:
>> @@ -4851,11 +4851,10 @@ void register_cp_regs_for_features(ARMCPU *cpu)
>>                .opc0 = 3, .opc1 = 0, .crn = 0, .crm = 2, .opc2 = 6,
>>                .access = PL1_R, .type = ARM_CP_CONST,
>>                .resetvalue = cpu->id_mmfr4 },
>> -            /* 7 is as yet unallocated and must RAZ */
>> -            { .name = "ID_ISAR7_RESERVED", .state = ARM_CP_STATE_BOTH,
> 
> You added this in
> 
>     if (arm_feature(env, ARM_FEATURE_V6)) {
> 
> Shouldn't this stay same and a new entry added later in
> 
>     if (arm_feature(env, ARM_FEATURE_V8)) {
> 
> ?
> 
>> +            { .name = "ID_ISAR6", .state = ARM_CP_STATE_BOTH,
> 
> If added under ARM_FEATURE_V8, shouldn't this be ARM_CP_STATE_AA32?

You'll notice that I'm replacing an entry that
was previously marked "reserved".

I'm not going to second-guess that.


r~