Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

[Greg Kurz]

On Fri, 29 Jun 2018 12:40:40 +0200
Paolo Bonzini <address@hidden> wrote:

> On 29/06/2018 12:39, Daniel P. Berrangé wrote:
> >> Also asserting current_machine != NULL is not necessary, since you're
> >> immediately dereferencing it.  
> > Is there a practical way to simply initialize the accelerators earlier
> > in startup sequence, so we just remove or at least reduce, the liklihood
> > of accessing it too early ?  
> 
> We can try, though not for 3.0 of course.
> 

FWIW, the motivation for this patch was kvm_enabled() being called under
the class_init function of the machine TypeInfo. This happens way earlier
than accelerator init. Not sure this is doable, but I can have a look.

> Paolo