[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD |
Date: |
Fri, 29 Jun 2018 13:00:57 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 05/20/2014 01:04 AM, Fam Zheng wrote:
Thanks for Eric's and Markus' reviewing!
Thread necromancy - now that patch 15/15 has had a revival four years
later (two different threads proposing a test 222 for image fleecing) -
I want to double check if anything else in this series still needs
forward porting.
v20: Rebase to master, with minor improvements as listed below:
[02/15] block: Introduce op_blockers to BlockDriverState
Better error message in bdrv_op_is_blocked. (Markus)
[03/15] block: Replace in_use with operation blocker
Accurate commit message: why use bdrv_op_blocker_is_empty in
block_job_create. (Markus)
[06/15] block: Add backing_blocker in BlockDriverState
Drop error_is_set().
Call error_free() unconditionally.
[08/15] block: Support dropping active in bdrv_drop_intermediate
Fix list index in function comment. (Eric)
[13/15] block: Add blockdev-backup to transaction
Drop error_is_set().
[14/15] qemu-iotests: Test blockdev-backup in 055
Bump year in file header. (Eric)
Fam Zheng (15):
block: Add BlockOpType enum
block: Introduce op_blockers to BlockDriverState
block: Replace in_use with operation blocker
block: Move op_blocker check from block_job_create to its caller
block: Add bdrv_set_backing_hd()
block: Add backing_blocker in BlockDriverState
Before this point looks to be in master (in some form or another); after
this point did not have any review.
block: Parse "backing" option to reference existing BDS
block: Support dropping active in bdrv_drop_intermediate
stream: Use bdrv_drop_intermediate and drop close_unused_images
commit: Use bdrv_drop_intermediate
qmp: Add command 'blockdev-backup'
block: Allow backup on referenced named BlockDriverState
block: Add blockdev-backup to transaction
qemu-iotests: Test blockdev-backup in 055
qemu-iotests: Image fleecing test case 089
block-migration.c | 7 +-
block.c | 310 +++++++++++++++++++++++++++-------------
block/backup.c | 26 ++++
block/commit.c | 2 +-
block/mirror.c | 9 +-
block/stream.c | 42 +-----
blockdev.c | 122 ++++++++++++++--
blockjob.c | 14 +-
hw/block/dataplane/virtio-blk.c | 18 ++-
include/block/block.h | 29 +++-
include/block/block_int.h | 9 +-
include/block/blockjob.h | 3 +
qapi-schema.json | 52 +++++++
qmp-commands.hx | 44 ++++++
tests/qemu-iotests/055 | 277 +++++++++++++++++++++++++++++------
tests/qemu-iotests/055.out | 4 +-
tests/qemu-iotests/089 | 99 +++++++++++++
tests/qemu-iotests/089.out | 5 +
tests/qemu-iotests/group | 1 +
19 files changed, 856 insertions(+), 217 deletions(-)
create mode 100755 tests/qemu-iotests/089
create mode 100644 tests/qemu-iotests/089.out
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD,
Eric Blake <=