[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unkno
From: |
Zhang Chen |
Subject: |
Re: [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode. |
Date: |
Sat, 30 Jun 2018 10:00:27 +0800 |
On Fri, Jun 29, 2018 at 5:14 PM, Dr. David Alan Gilbert <address@hidden
> wrote:
> * Eric Blake (address@hidden) wrote:
> > On 06/27/2018 03:41 PM, Zhang Chen wrote:
> > > From: Zhang Chen <address@hidden>
> > >
> > > Suggested by Markus Armbruster rename COLO unknown mode to none mode.
> > >
> > > Signed-off-by: Zhang Chen <address@hidden>
> > > ---
> > > migration/colo-failover.c | 2 +-
> > > migration/colo.c | 2 +-
> > > qapi/migration.json | 10 +++++-----
> > > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > > # Since: 2.8
> > > ##
> > > { 'enum': 'COLOMode',
> > > - 'data': [ 'unknown', 'primary', 'secondary'] }
> > > + 'data': [ 'none', 'primary', 'secondary'] }
> >
> > The deletion of 'unknown' could potentially be a user-visible regression
> > visible if COLOMode were in a QMP command; but thankfully the generated
> > qapi/qapi-introspect.c does not seem to cover this enum, so it just
> affects
> > internal code for now.
>
> Note that the migration capability to enable colo is still x-colo;
> so I take that to mean we've still got a free hand to change any part of
> the COLO interface until we're happy it's right.
>
> Dave
>
>
Thanks Eric and Dave.
Zhang Chen
> > Reviewed-by: Eric Blake <address@hidden>
> >
> > --
> > Eric Blake, Principal Software Engineer
> > Red Hat, Inc. +1-919-301-3266
> > Virtualization: qemu.org | libvirt.org
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>
- [Qemu-devel] [PATCH V9 04/20] COLO: integrate colo compare with colo frame, (continued)
- [Qemu-devel] [PATCH V9 04/20] COLO: integrate colo compare with colo frame, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 05/20] COLO: Add block replication into colo process, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 06/20] COLO: Remove colo_state migration struct, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 07/20] COLO: Load dirty pages into SVM's RAM cache firstly, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 08/20] ram/COLO: Record the dirty pages that SVM received, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 09/20] COLO: Flush memory data from ram cache, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 10/20] qmp event: Add COLO_EXIT event to notify users while exited COLO, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode., Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 12/20] qapi: Add new command to query colo status, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 14/20] COLO: flush host dirty ram from cache, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 13/20] savevm: split the process of different stages for loadvm/savevm, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 15/20] net/net.c: Add net client type check function for COLO, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 16/20] filter: Add handle_event method for NetFilterClass, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 17/20] filter-rewriter: handle checkpoint and failover event, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 18/20] COLO: notify net filters about checkpoint/failover event, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 19/20] COLO: quick failover process by kick COLO thread, Zhang Chen, 2018/06/27
- [Qemu-devel] [PATCH V9 20/20] docs: Add COLO status diagram to COLO-FT.txt, Zhang Chen, 2018/06/27