Re: [Qemu-devel] [PATCH 3/3] audio: add audio timer trace points

[Daniel P . Berrangé]

On Mon, Jul 02, 2018 at 05:50:07PM +0200, Gerd Hoffmann wrote:
> On Mon, Jul 02, 2018 at 12:25:37PM -0300, Philippe Mathieu-Daudé wrote:
> > Hi Gerd,
> > 
> > On 07/02/2018 11:55 AM, Gerd Hoffmann wrote:
> > > Track audio timer starts and stops.  Also trace delayed audio timer calls.
> > > 
> > > Signed-off-by: Gerd Hoffmann <address@hidden>
> > > ---
> > >  audio/audio.c      | 28 +++++++++++++++++++++++++---
> > >  audio/trace-events |  5 +++++
> > >  2 files changed, 30 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/audio/audio.c b/audio/audio.c
> > > index d6e91901aa..d055b2236c 100644
> > > --- a/audio/audio.c
> > > +++ b/audio/audio.c
> > > @@ -29,6 +29,7 @@
> > >  #include "sysemu/sysemu.h"
> > >  #include "qemu/cutils.h"
> > >  #include "sysemu/replay.h"
> > > +#include "audio/trace.h"
> > 
> > Can you simply use "trace.h" like in the rest of the codebase?
> 
> Why?  I need the audio trace points only, and including only those
> avoids object rebuilds in case some unrelated trace points are updated.

There is no global 'trace.h' any more - an unqualified  #include "trace.h"
will resolve to the local build directory first, so still pull in the same
audio/trace.h

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|