[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] blockdev: enable non-root nodes for backup sourc
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 3/6] blockdev: enable non-root nodes for backup source |
Date: |
Mon, 2 Jul 2018 20:37:27 -0500 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
This is needed to implement the image-fleecing workflow where we
create a temporary node backed by an active node, then start
backupdev-backup sync=none from the active node to the temp node.
In this case, the active node is now a root node AND a backing node,
so it no longer qualifies as a root node, so we loosen the restriction
on which nodes can be considered as the source for a backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: John Snow <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
---
blockdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 58d75709327..72f5347df5f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1859,7 +1859,7 @@ static void blockdev_backup_prepare(BlkActionState
*common, Error **errp)
assert(common->action->type == TRANSACTION_ACTION_KIND_BLOCKDEV_BACKUP);
backup = common->action->u.blockdev_backup.data;
- bs = qmp_get_root_bs(backup->device, errp);
+ bs = bdrv_lookup_bs(backup->device, backup->device, errp);
if (!bs) {
return;
}
@@ -3517,7 +3517,7 @@ BlockJob *do_blockdev_backup(BlockdevBackup *backup,
JobTxn *txn,
backup->compress = false;
}
- bs = qmp_get_root_bs(backup->device, errp);
+ bs = bdrv_lookup_bs(backup->device, backup->device, errp);
if (!bs) {
return NULL;
}
--
2.14.4
- [Qemu-devel] [PULL 0/6] NBD patches for 2018-07-02 (3.0 soft freeze), Eric Blake, 2018/07/02
- [Qemu-devel] [PULL 1/6] nbd/server: Fix dirty bitmap logic regression, Eric Blake, 2018/07/02
- [Qemu-devel] [PULL 2/6] iscsi: Avoid potential for get_status overflow, Eric Blake, 2018/07/02
- [Qemu-devel] [PULL 3/6] blockdev: enable non-root nodes for backup source,
Eric Blake <=
- [Qemu-devel] [PULL 5/6] nbd/client: Add x-dirty-bitmap to query bitmap from server, Eric Blake, 2018/07/02
- [Qemu-devel] [PULL 6/6] iotests: New test 223 for exporting dirty bitmap over NBD, Eric Blake, 2018/07/02
- [Qemu-devel] [PULL 4/6] iotests: add 222 to test basic fleecing, Eric Blake, 2018/07/02
- Re: [Qemu-devel] [PULL 0/6] NBD patches for 2018-07-02 (3.0 soft freeze), Peter Maydell, 2018/07/03