qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/32] qmp qemu-ga: Fix qemu-ga not to accept "c


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 11/32] qmp qemu-ga: Fix qemu-ga not to accept "control"
Date: Mon, 2 Jul 2018 20:49:43 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/02/2018 11:21 AM, Markus Armbruster wrote:
Commit cf869d53172 "qmp: support out-of-band (oob) execution"
accidentally made qemu-ga accept and ignore "control".  Fix that.

Out-of-band execution in a monitor that doesn't support it now fails
with

     {"error": {"class": "GenericError", "desc": "QMP input member 'control' is 
unexpected"}}

instead of

     {"error": {"class": "GenericError", "desc": "Please enable out-of-band first 
for the session during capabilities negotiation"}}

The old description is suboptimal when out-of-band cannot not be
enabled, or the command doesn't support out-of-band execution.

The new description is a bit unspecific, but it'll do.

Signed-off-by: Markus Armbruster <address@hidden>
---
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]