Re: [Qemu-devel] [PATCH 22/32] qmp: De-duplicate error response building

[Eric Blake]

On 07/02/2018 11:22 AM, Markus Armbruster wrote:
> All callers of qmp_build_error_object() duplicate the code to wrap it
> in a response object.  Replace it by qmp_error_response() that
> captures the duplicated code, including error_free().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   include/qapi/qmp/dispatch.h |  2 +-
>   monitor.c                   |  7 +------
>   qapi/qmp-dispatch.c         | 20 +++++++++++---------
>   qga/main.c                  |  8 ++------
>   4 files changed, 15 insertions(+), 22 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org