Re: [Qemu-devel] [PATCH v6 09/15] qapi-introspect: add preprocessor conditions to generated QLit

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

[...]
> Let's add a hint to the commit message.  Pergaps:
>
>     qapi-introspect: add preprocessor conditions to generated QLit
>
>     This commit adds 'ifcond' conditions to top-level QLit objects.
>     Future work will add them to object and enum type members, i.e. within
>     QLit objects.
>
>     Extend the QLit generator to_qlit() to accept (@obj, @cond) tuples in
>     addition to just @obj.  The tuple causes the QLit generated for
>     objects for @obj with #if/#endif conditions for @cond.
>
>     See generated tests/test-qmp-introspect.c.  Example diff after this
>     patch:
>     [...]

With that,
Reviewed-by: Markus Armbruster <address@hidden>