[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/14] qga: unset frozen state if no mount points are
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PULL 01/14] qga: unset frozen state if no mount points are frozen |
Date: |
Tue, 3 Jul 2018 15:52:08 -0500 |
From: Chen Hanxiao <address@hidden>
If we set mountpoints to qmp_guest_fsfreeze_freeze_list,
we may got nothing to freeze as all mountpoints are
not valid.
So call ga_unset_frozen in this senario.
Also, if we return 0 frozen fs, there is no need to call
guest-fsfreeze-thaw.
Cc: Michael Roth <address@hidden>
Signed-off-by: Chen Hanxiao <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
---
qga/commands-posix.c | 6 ++++++
qga/qapi-schema.json | 4 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index eae817191b..594d21ef3e 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1274,6 +1274,12 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool
has_mountpoints,
}
free_fs_mount_list(&mounts);
+ /* We may not issue any FIFREEZE here.
+ * Just unset ga_state here and ready for the next call.
+ */
+ if (i == 0) {
+ ga_unset_frozen(ga_state);
+ }
return i;
error:
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 17884c7c70..1045cef386 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -435,7 +435,9 @@
# for up to 10 seconds by VSS.
#
# Returns: Number of file systems currently frozen. On error, all filesystems
-# will be thawed.
+# will be thawed. If no filesystems are frozen as a result of this call,
+# then @guest-fsfreeze-status will remain "thawed" and calling
+# @guest-fsfreeze-thaw is not necessary.
#
# Since: 0.15.0
##
--
2.11.0
- [Qemu-devel] [PULL 10/14] qga: bios_supports_mode: decoupling pm-utils and sys logic, (continued)
- [Qemu-devel] [PULL 10/14] qga: bios_supports_mode: decoupling pm-utils and sys logic, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 06/14] qga/schema: fix documentation for GuestOSInfo, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 13/14] qga: systemd hibernate/suspend/hybrid-sleep support, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 04/14] qga-win: add driver path usage to GuestFilesystemInfo, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 09/14] qga: refactoring qmp_guest_suspend_* functions, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 05/14] test-qga: add trivial tests for some commands, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 08/14] qemu-ga: make get-fsinfo work over pci bridges, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 11/14] qga: guest_suspend: decoupling pm-utils and sys logic, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 07/14] qga-win: Fixing msi upgrade disallow in WiX file, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 14/14] qga: removing bios_supports_mode, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 01/14] qga: unset frozen state if no mount points are frozen,
Michael Roth <=
- [Qemu-devel] [PULL 12/14] qga: removing switch statements, adding run_process_child, Michael Roth, 2018/07/03
- [Qemu-devel] [PULL 03/14] qga: add mountpoint usage info to GuestFilesystemInfo, Michael Roth, 2018/07/03
- Re: [Qemu-devel] [PULL 00/14] qga patch queue for soft-freeze, Peter Maydell, 2018/07/05