Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

[Alex Bennée]

Programmingkid <address@hidden> writes:

>> On Jul 4, 2018, at 10:15 AM, Alex Bennée <address@hidden> wrote:
>>
>>
>> Richard Henderson <address@hidden> writes:
>>
>>>
>>> Anyway, all of this has been broken long enough that it'll need to
>>> wait til next devel cycle before anything further gets done.
>>
>> When it gets done should we add some explicit ppc tests to tests/tcg/ppc
>> like we did with arm64 fcvt or would it be worth spending more time on
>> the general purpose FP test suite Emilio was working on as part of his
>> hard-float series?
>
> My vote goes to adding PowerPC specific tests. I already made some and sent 
> them to the list a couple of days ago. A general purpose floating point test 
> suite would probably not be able to test things like PowerPC floating point 
> flags.
>
> I'm not certain how we would add floating point tests to QEMU. I'm
> guessing it would involve some kind of bootable image file that would
> load and run the tests. Hopefully there is an easier way to implement
> testing.

You don't need system tests - this is all testable from linux-user. See
tests/tcg/arm/fcvt.c and the .ref files in arm and aarch64 directories.
Assuming the test isn't insane (like test-i386-fprem) we can just add a
reference output recorded on know good hardware.

--
Alex Bennée