Re: [Qemu-devel] [PATCH] configure: Do not display host compilers as cross-compilers

[Daniel P . Berrangé]

On Wed, Jul 04, 2018 at 05:21:49PM +0100, Alex Bennée wrote:
> 
> Daniel P. Berrangé <address@hidden> writes:
> 
> > On Wed, Jul 04, 2018 at 04:41:30PM +0100, Alex Bennée wrote:
> >>
> >> Philippe Mathieu-Daudé <address@hidden> writes:
> >>
> >> > This silent (since d75402b5ee2):
> >> >
> >> >   ./configure
> >> >   [...]
> >> >   NOTE: cross-compilers enabled:  'cc'
> >> >
> >> > Reported-by: Dr. David Alan Gilbert <address@hidden>
> >> > Reported-by: Daniel P. Berrangé <address@hidden>
> >> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> >> > ---
> >> >  configure | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/configure b/configure
> >> > index b99ebdde24..fbb53ab6bb 100755
> >> > --- a/configure
> >> > +++ b/configure
> >> > @@ -7328,7 +7328,7 @@ echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
> >> >
> >> >  done # for target in $targets
> >> >
> >> > -if test -n "$enabled_cross_compilers"; then
> >> > +if test -n "$target_compiler" -a -n "$enabled_cross_compilers"; then
> >> >      echo
> >> >      echo "NOTE: cross-compilers enabled: $enabled_cross_compilers"
> >> >  fi
> >>
> >> I had also added:
> >>
> >> -    echo "NOTE: cross-compilers enabled: $enabled_cross_compilers"
> >> +    echo "NOTE: compilers enabled for TCG tests: 
> >> $enabled_cross_compilers"[
> >>
> >> to make things clearer.
> >
> > I think we should also 's/NOTE: //', because everything printed by
> > configure at the end is a note. Also get rid of the extra blank
> > line before it.
> 
> *shrugs* I made the original decision because:
> 
> WARNING: Use of SDL 1.2 is deprecated and will be removed in
> WARNING: future releases. Please switch to using SDL 2.0
> compilers enabled for TCG tests:  'aarch64-linux-gnu-gcc' 
> 'arm-linux-gnueabihf-gcc' 'cc' 'aarch64-linux-gnu-gcc' 
> 'arm-linux-gnueabihf-gcc' 'cc'
> 
> offended my eye, but I'm happy either way really.

Oh, I see - can we move the print out before the WARNING, as
those warnings were intended to be the last thing that was
printed. All the feature summaries were supposed to come first.

IIRC, we'll be able to delete the SDL/GTK deprecation messages
when 3.1 opens anyway, because they'll have been present for
both 2.12 and 3.0 already.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|