[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Workaround for checkpatch.p
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c |
Date: |
Wed, 4 Jul 2018 17:11:03 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Hi Aleksandar,
On 07/04/2018 04:30 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> If checkpatch.pl is applied (using switch "-f") on file
> target/mips/msa_helper.c, it will hang.
>
> This is a workaround by correcting the source file. The workaround is
> found by partial deleting and undeleting of the code in msa_helper.c
> in binary search fashion.
>
> The bug (for checkpatch.pl) is already reported to the qemu-devel list.
Paolo already sent a fix for this bug:
http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01250.html
Can you test it?
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> target/mips/msa_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c
> index c74e3cd..1691b70 100644
> --- a/target/mips/msa_helper.c
> +++ b/target/mips/msa_helper.c
> @@ -2750,8 +2750,8 @@ void helper_msa_ftq_df(CPUMIPSState *env, uint32_t df,
> uint32_t wd,
>
> #define FMAXMIN_A(F, G, X, _S, _T, BITS, STATUS) \
> do { \
> - uint## BITS ##_t S = _S, T = _T; \
> - uint## BITS ##_t as, at, xs, xt, xd; \
> + uint## BITS ## _t S = _S, T = _T; \
> + uint## BITS ## _t as, at, xs, xt, xd; \
> if (NUMBER_QNAN_PAIR(S, T, BITS, STATUS)) { \
> T = S; \
> } \
>
- [Qemu-devel] [PATCH v3 0/8] target/mips: Maintenance and misc fixes and improvements, Aleksandar Markovic, 2018/07/04
- [Qemu-devel] [PATCH v3 1/8] target/mips: Update maintainer's email addresses, Aleksandar Markovic, 2018/07/04
- [Qemu-devel] [PATCH v3 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c, Aleksandar Markovic, 2018/07/04
- Re: [Qemu-devel] [PATCH v3 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 3/8] target/mips: Update some CP0 registers bit definitions, Aleksandar Markovic, 2018/07/04
- [Qemu-devel] [PATCH v3 4/8] target/mips: Avoid case statements formulated by ranges, Aleksandar Markovic, 2018/07/04
- [Qemu-devel] [PATCH v3 5/8] target/mips: Add CP0 BadInstrX register, Aleksandar Markovic, 2018/07/04