[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 12/20] docker: ubuntu: Update the package list bef
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL v3 12/20] docker: ubuntu: Update the package list before installing new ones |
Date: |
Thu, 5 Jul 2018 17:03:21 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
Since docker caches the different layers, updating the package
list does not invalidate the previous "apt-get update" layer,
and it is likely "apt-get install" hits an outdated repository.
See
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get
This fixes:
$ make docker-image-ubuntu V=1
./tests/docker/docker.py build qemu:ubuntu
tests/docker/dockerfiles/ubuntu.docker --add-current-user
Sending build context to Docker daemon 3.072kB
[...]
E: Failed to fetch
http://archive.ubuntu.com/ubuntu/pool/main/m/mesa/libgles2-mesa_17.0.7-0ubuntu0.16.04.2_amd64.deb
404 Not Found
E: Failed to fetch
http://archive.ubuntu.com/ubuntu/pool/main/m/mesa/libgles2-mesa-dev_17.0.7-0ubuntu0.16.04.2_amd64.deb
404 Not Found
E: Unable to fetch some archives, maybe run apt-get update or try with
--fix-missing?
The command '/bin/sh -c apt-get -y install $PACKAGES' returned a non-zero
code: 100
tests/docker/Makefile.include:40: recipe for target 'docker-image-ubuntu'
failed
make: *** [docker-image-ubuntu] Error 1
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
diff --git a/tests/docker/dockerfiles/ubuntu.docker
b/tests/docker/dockerfiles/ubuntu.docker
index dabbf2a8a4..c03520ce3f 100644
--- a/tests/docker/dockerfiles/ubuntu.docker
+++ b/tests/docker/dockerfiles/ubuntu.docker
@@ -1,7 +1,6 @@
FROM ubuntu:16.04
RUN echo "deb http://archive.ubuntu.com/ubuntu/ trusty universe multiverse" >>
\
/etc/apt/sources.list
-RUN apt-get update
ENV PACKAGES flex bison \
libusb-1.0-0-dev libiscsi-dev librados-dev libncurses5-dev
libncursesw5-dev \
libseccomp-dev libgnutls-dev libssh2-1-dev libspice-server-dev \
@@ -13,6 +12,7 @@ ENV PACKAGES flex bison \
libjemalloc-dev libcacard-dev libusbredirhost-dev libnfs-dev libcap-dev
libattr1-dev \
texinfo \
gettext git make ccache python-yaml gcc clang sparse
-RUN apt-get -y install $PACKAGES
+RUN apt-get update && \
+ apt-get -y install $PACKAGES
RUN dpkg -l $PACKAGES | sort > /packages.txt
ENV FEATURES clang pyyaml
--
2.17.1
- [Qemu-devel] [PULL v3 00/20] Travis, Code Coverage and Cross Build updates, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 01/20] Revert "Makefile: Rename TARGET_DIRS to TARGET_LIST", Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 04/20] build-system: remove per-test GCOV reporting, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 05/20] .gitignore: add .gcov files, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 03/20] travis: test out-of-tree builds, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 12/20] docker: ubuntu: Update the package list before installing new ones,
Alex Bennée <=
- [Qemu-devel] [PULL v3 10/20] linux-user: introduce preexit_cleanup, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 13/20] docker: ubuntu: Use SDL2, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 19/20] docker: add special rule for deboostrapped images, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 06/20] docker: add gcovr to travis image, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 08/20] build-system: add clean-coverage target, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 02/20] travis: do not waste time cloning unused submodules, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 07/20] travis: add gcovr summary for GCOV build, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 11/20] linux-user: add gcov support to preexit_cleanup, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 15/20] docker: Do not run tests in 'intermediate' images, Alex Bennée, 2018/07/05
- [Qemu-devel] [PULL v3 09/20] build-system: add coverage-report target, Alex Bennée, 2018/07/05