Re: [Qemu-devel] [PATCH] translate-all: honour CF_NOCACHE in tb_gen_code

[Richard Henderson]

On 07/05/2018 09:07 AM, Emilio G. Cota wrote:
> This fixes a record-replay regression introduced by 95590e2
> ("translate-all: discard TB when tb_link_page returns an existing
> matching TB", 2018-06-15). The problem is that code using CF_NOCACHE
> assumes that the TB returned from tb_gen_code is always a
> newly-generated one. This assumption, however, was broken in
> the aforementioned commit.
> 
> Fix it by honouring CF_NOCACHE, so that tb_gen_code always
> returns a newly-generated TB when CF_NOCACHE is passed to it.
> Do this by avoiding the TB hash table if CF_NOCACHE is set.
> 
> Reported-by: Pavel Dovgalyuk <address@hidden>
> Tested-by: Pavel Dovgalyuk <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  accel/tcg/translate-all.c | 34 +++++++++++++++++++---------------
>  1 file changed, 19 insertions(+), 15 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~