[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 00/12] RFC: monitor: various code simplification and
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 00/12] RFC: monitor: various code simplification and fixes |
Date: |
Fri, 6 Jul 2018 14:13:42 +0200 |
Hi,
This series is a rebased subset of "[PATCH v3 00/38] RFC: monitor: add
asynchronous command type" with code cleanups and improvements that
are worth to consider for 3.0.
The series applies on master, and will conflict with the pending
series "[PATCH 0/9] monitor: enable OOB by default" from Peter.
In particular, reverting "qmp: isolate responses into io thread" is
quite intrusive, but is a nice simplification that is worth to
consider before modifying/maintaining it further. Also, "monitor: no
need to save need_resume" could be dropped if Peter "[PATCH 5/9]
monitor: suspend monitor instead of send CMD_DROP" is adopted (see
discussion about need_resume there).
The last patch, "RFC: qmp: rework 'id' handling" simplifies a bit
monitor "id" handling, and makes qemu-ga conform to the QMP
specification by copying "id" from the request in the reply. This is
the opposite to Markus change "qmp qemu-ga: Revert change that
accidentally made qemu-ga accept 'id'".
(the first patch is already in Markus qapi-next branch, it is there
for patchew testing)
Marc-André Lureau (12):
tests: change /0.15/* tests to /qmp/*
monitor: consitify qmp_send_response() QDict argument
qmp: constify qmp_is_oob()
Revert "qmp: isolate responses into io thread"
monitor: no need to save need_resume
qga: process_event() simplification and leak fix
json-parser: always set an error if return NULL
json-lexer: make it safe to call multiple times
tests: add a few qemu-qmp tests
tests: add a qmp success-response test
qga: process_event() simplification
RFC: qmp: rework 'id' handling
include/qapi/qmp/dispatch.h | 2 +-
block.c | 5 -
monitor.c | 171 +++---------------------
qapi/qmp-dispatch.c | 12 +-
qapi/qobject-input-visitor.c | 5 -
qga/main.c | 66 +++------
qobject/json-lexer.c | 5 +-
qobject/json-parser.c | 8 +-
tests/qmp-test.c | 38 ++++++
tests/test-qga.c | 13 +-
tests/test-qmp-cmds.c | 27 +++-
tests/qapi-schema/qapi-schema-test.json | 2 +
tests/qapi-schema/qapi-schema-test.out | 2 +
13 files changed, 129 insertions(+), 227 deletions(-)
--
2.18.0.rc1
[Qemu-devel] [PATCH 05/12] monitor: no need to save need_resume, Marc-André Lureau, 2018/07/06