Re: [Qemu-devel] [PATCH for 3.0 10/10] docker: add expansion for docker-test-FOO to Makefile.include

[Philippe Mathieu-Daudé]

On 07/09/2018 12:21 PM, Alex Bennée wrote:
> This allows us to run a particular test on all docker images. For
> example:
> 
>   make docker-test-unit
> 
> Will run the unit tests on every supported image.
> 
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  tests/docker/Makefile.include | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index fe63aacf69..765b2c36f2 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -152,6 +152,7 @@ $(foreach i,$(filter-out 
> $(DOCKER_PARTIAL_IMAGES),$(DOCKER_IMAGES) $(DOCKER_DEPR
>       ) \
>       $(foreach t,$(DOCKER_TESTS), \
>               $(eval docker-test: address@hidden) \
> +             $(eval docker-$t: address@hidden) \
>       ) \
>  )
>  
> @@ -162,6 +163,7 @@ docker:
>       @echo
>       @echo '    docker:              Print this help.'
>       @echo '    docker-test:         Run all image/test combinations.'

Can we rename "docker-test" -> "docker-tests" or is it too late?

> +     @echo '    docker-TEST:         Run TEST on all image combinations.'
>       @echo '    docker-clean:        Kill and remove residual docker testing 
> containers.'
>       @echo '    address@hidden:   Run "TEST" in container "IMAGE".'
>       @echo '                         Note: "TEST" is one of the listed test 
> name,'
>