[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0] target/arm: Fix LD1W and LDFF1W (scalar
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH for-3.0] target/arm: Fix LD1W and LDFF1W (scalar plus vector) |
Date: |
Wed, 11 Jul 2018 13:04:38 +0200 |
Hello,
On Wed, Jul 11, 2018 at 12:39 PM, Richard Henderson
<address@hidden> wrote:
> 'I' was being double-incremented; correctly within the inner loop
> and incorrectly within the outer loop.
>
> Signed-off-by: Richard Henderson <address@hidden>
I didn't try to apply the patch but line numbers look wrong.
I guess this should apply to DO_LD1_ZPZ_S and DO_LDFF1_ZPZ macros, in
which case you get my review:
Reviewed-by: Laurent Desnogues <address@hidden>
Thanks,
Laurent
> ---
>
> Fixes a SIGSEGV within one of these generated helpers,
> exposed by an armclang vectorized code sample.
>
>
> r~
>
> ---
> target/arm/sve_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index cec0d3ee54..ddc592ff79 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -4855,7 +4855,7 @@ void HELPER(NAME)(CPUARMState *env, void *vd, void *vg,
> void *vm, \
> intptr_t i, oprsz = simd_oprsz(desc); \
> unsigned scale = simd_data(desc); \
> uintptr_t ra = GETPC(); \
> - for (i = 0; i < oprsz; i++) { \
> + for (i = 0; i < oprsz; ) { \
> uint16_t pg = *(uint16_t *)(vg + H1_2(i >> 3)); \
> do { \
> TYPEM m = 0; \
> @@ -4936,7 +4936,7 @@ void HELPER(NAME)(CPUARMState *env, void *vd, void *vg,
> void *vm, \
> uintptr_t ra = GETPC(); \
> bool first = true; \
> mmap_lock(); \
> - for (i = 0; i < oprsz; i++) { \
> + for (i = 0; i < oprsz; ) { \
> uint16_t pg = *(uint16_t *)(vg + H1_2(i >> 3)); \
> do { \
> TYPEM m = 0; \
> --
> 2.17.1
>
>