[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved()
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2] linux-user: fix mmap_find_vma_reserved() |
Date: |
Wed, 11 Jul 2018 15:44:27 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/11/2018 01:27 PM, Laurent Vivier wrote:
> Richard,
>
> I think this fix could be merged into your "linux-user: Fix shmat
> emulation by honoring host SHMLBA" patch, by adding something like this
> instead:
Well, not "instead", but "in addition".
Nothing works right when the guest adjustment itself is unaligned, as is the
case with reserved_va as you noted, and with (non-reserved) guest_base as I
noted in that patch.
For v2, I'll split the guest_base fix out to a separate patch.
r~