[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 3.0 02/10] docker: debian-tricore add git to
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH for 3.0 02/10] docker: debian-tricore add git tools |
Date: |
Thu, 12 Jul 2018 11:44:12 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 07/09/2018 12:21 PM, Alex Bennée wrote:
>> As we check out we need git installed before we start. We would have
>> had this based on the heavier qemu:debian9 image but we only use plain
>> debian:9 here.
>
> I first thought "weird, I checked this already" then noticed you rebased
> on debian:9.
> 'stretch-slim' is an alias for '9-slim' and should be tinier (the
> previous RFC image is 323MB).
Hmm why not just switch to qemu:debian9 as we need the compiler as well?
It's not like there will be many users only carrying this image in their
docker setup.
>
>> Signed-off-by: Alex Bennée <address@hidden>> ---
>> tests/docker/dockerfiles/debian-tricore-cross.docker | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker
>> b/tests/docker/dockerfiles/debian-tricore-cross.docker
>> index 898b8dd511..5ba3ca88a7 100644
>> --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
>> +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
>> @@ -11,6 +11,9 @@ FROM debian:9
>>
>> MAINTAINER Philippe Mathieu-Daudé <address@hidden>
>>
>> +RUN apt-get update && \
>> + DEBIAN_FRONTEND=noninteractive apt-get install -yy git
>> +
>> RUN git clone --single-branch \
>> https://github.com/bkoppelmann/tricore-binutils.git \
>> /usr/src/binutils && \
>>
--
Alex Bennée