[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: replace scrollingDeltaY with del
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: replace scrollingDeltaY with deltaY |
|
Date: |
Thu, 12 Jul 2018 16:50:59 +0100 |
On 11 July 2018 at 22:18, Peter Maydell <address@hidden> wrote:
> On 9 July 2018 at 16:02, John Arbuckle <address@hidden> wrote:
>> The NSEvent class method scrollingDeltaY is available
>> for Mac OS 10.7 and newer. Since QEMU supports Mac OS
>> 10.5 and up, we need to be using a method that is
>> available on these version of Mac OS X. The deltaY
>> method is a method that does the same thing as
>> scrollingDeltaY and is available on Mac OS 10.5 and
>> up. So we replace scrollingDeltaY with deltaY.
>>
>> We only check deltaY's value if it is not zero
>> because zero means no scrolling took place.
> I'll tweak the comments and put this in for 3.0 rc1.
Now applied to master, thanks.
-- PMM