Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by

From:	Thomas Huth
Subject:	Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail()
Date:	Thu, 12 Jul 2018 20:17:05 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 12.07.2018 13:12, Markus Armbruster wrote:
> Commit ab45015a968 "qobject: Let qobject_from_jsonf() fail instead of
> abort" removed only one of two ways qobject_from_jsonf() can abort.
> Wrong.

Wrong because it calls qobject_from_jsonv() with error_abort. Maybe
mentioned that in the patch description - since it took me a while to
understand what you mean here.

Reviewed-by: Thomas Huth <address@hidden>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [Qemu-devel] [PATCH 04/20] libqtest: Clean up how we read the QMP greeting, (continued)
- [Qemu-devel] [PATCH 10/20] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 10/20] tests: Pass literal format strings directly to qmp_FOO(), Philippe Mathieu-Daudé, 2018/07/12
- [Qemu-devel] [PATCH 07/20] libqtest: Simplify qmp_fd_vsend() a bit, Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 07/20] libqtest: Simplify qmp_fd_vsend() a bit, Philippe Mathieu-Daudé, 2018/07/12
- [Qemu-devel] [PATCH 17/20] migration-test: Clean up string interpolation into QMP, part 1, Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 17/20] migration-test: Clean up string interpolation into QMP, part 1, Juan Quintela, 2018/07/12
- [Qemu-devel] [PATCH 20/20] libqtest: Enable compile-time format string checking, Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 20/20] libqtest: Enable compile-time format string checking, Philippe Mathieu-Daudé, 2018/07/12
- [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail(), Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail(), Thomas Huth <=
    - Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail(), Markus Armbruster, 2018/07/16
- [Qemu-devel] [PATCH 19/20] migration-test: Clean up string interpolation into QMP, part 3, Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 19/20] migration-test: Clean up string interpolation into QMP, part 3, Juan Quintela, 2018/07/12
- [Qemu-devel] [PATCH 13/20] tests: Clean up string interpolation around qtest_qmp_device_add(), Markus Armbruster, 2018/07/12
- [Qemu-devel] [PATCH 11/20] tests: Clean up string interpolation into QMP input (simple cases), Markus Armbruster, 2018/07/12
  - Re: [Qemu-devel] [PATCH 11/20] tests: Clean up string interpolation into QMP input (simple cases), Philippe Mathieu-Daudé, 2018/07/12
    - Re: [Qemu-devel] [PATCH 11/20] tests: Clean up string interpolation into QMP input (simple cases), Markus Armbruster, 2018/07/16
- [Qemu-devel] [PATCH 08/20] test-qobject-input-visitor: Avoid format string ambiguity, Markus Armbruster, 2018/07/12

Prev by Date: Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines
Next by Date: Re: [Qemu-devel] [PATCH v2] Zero out the host's `msg_control` buffer
Previous by thread: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail()
Next by thread: Re: [Qemu-devel] [PATCH 05/20] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail()
Index(es):
- Date
- Thread