[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 03/29] chardev: unref if underlying chardev has n
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v4 03/29] chardev: unref if underlying chardev has no parent |
Date: |
Fri, 13 Jul 2018 15:08:50 +0200 |
It's possible to write code creating a chardev backend that is not
registered. When it is not user-created, it makes sense to keep it
hidden. Let the associated frontend destroy it also in this case.
Signed-off-by: Marc-André Lureau <address@hidden>
---
chardev/char-fe.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/chardev/char-fe.c b/chardev/char-fe.c
index f158f158f8..a8931f7afd 100644
--- a/chardev/char-fe.c
+++ b/chardev/char-fe.c
@@ -235,7 +235,12 @@ void qemu_chr_fe_deinit(CharBackend *b, bool del)
d->backends[b->tag] = NULL;
}
if (del) {
- object_unparent(OBJECT(b->chr));
+ Object *obj = OBJECT(b->chr);
+ if (obj->parent) {
+ object_unparent(obj);
+ } else {
+ object_unref(obj);
+ }
}
b->chr = NULL;
}
--
2.18.0.129.ge3331758f1
- [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 01/29] chardev: avoid crash if no associated address, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 03/29] chardev: unref if underlying chardev has no parent,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v4 02/29] chardev: remove qemu_chr_fe_read_all() counter, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 04/29] dmabuf: add y0_top, pass it to spice, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 06/29] libvhost-user: exit by default on VHOST_USER_NONE, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 05/29] vhost-user: simplify vhost_user_init/vhost_user_cleanup, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 07/29] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 08/29] Add vhost-user-backend, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 09/29] qio: add qio_channel_command_new_spawn_with_pre_exec(), Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 10/29] HACK: vhost-user-backend: allow to specify binary to execute, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 11/29] vhost-user: split vhost_user_read(), Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 12/29] vhost-user: add vhost_user_input_get_config(), Marc-André Lureau, 2018/07/13