Re: [Qemu-devel] [PATCH] vhost-user-test: added proper TestServer *dest initialization in test_migrate()

[Paolo Bonzini]

On 27/06/2018 12:05, Laurent Vivier wrote:
> On 26/06/2018 16:18, Emanuele Giuseppe Esposito wrote:
>> server->bus in _test_server_free() could be NULL, since TestServer *dest in 
>> test_migrate() was not properly initialized like TestServer *s.
>> Added init_virtio_dev(dest) and uninit_virtio_dev(dest), so the fields are 
>> properly set and when test_server_free(dest); is called, they can be 
>> correctly freed.
>>
>> The reason for that is init_virtio_dev() calls qpci_init_pc(), that creates 
>> a QPCIBusPC * (returned as QPCIBus *), while test_server_free() calls 
>> qpci_free_pc(),
>> that frees the QPCIBus *. Not calling init_virtio_dev() would leave the 
>> QPCIBus * of TestServer unset.
>>
>> Problem came out once I modified  pci-pc.c and pci-pc.h, modifying QPCIBusPC 
>> by adding another field before QPCIBus bus. Re-running the tests showed 
>> vhost-user-test failing.
>>
>> Signed-off-by: Emanuele Giuseppe Esposito <address@hidden>
> 
> Reviewed-by: Laurent Vivier <address@hidden>
> 
> I'm wondering if we have to have the same email address in both "From:"
> and "Signed-off-by"?
> 
> Thanks,
> Laurent
> 

Yes, it's better.  I have adjusted the Signed-off-by line.

Thanks,

Paolo