Re: [Qemu-devel] [PATCH for-3.0] qga: fix file descriptor leak

[Michael Roth]

Quoting Paolo Bonzini (2018-07-15 11:21:56)
> The file descriptor for /sys/power/state was never closed.  Reported
> by Coverity.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

Thanks, applied to qga tree:
  https://github.com/mdroth/qemu/commits/qga

> ---
>  qga/commands-posix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 233f78a406..4160aceaed 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -1651,6 +1651,7 @@ static bool linux_sys_state_supports_mode(SuspendMode 
> mode, Error **errp)
>      }
> 
>      ret = read(fd, buf, sizeof(buf) - 1);
> +    close(fd);
>      if (ret <= 0) {
>          return false;
>      }
> -- 
> 2.17.1
>