[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configu
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files |
Date: |
Tue, 17 Jul 2018 13:46:46 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Tue, Jul 17, 2018 at 01:33:38PM +0200, Juan Quintela wrote:
> If you don't want to compile everything, you configure
> config-devices.mak. And then make clean remove it, and make will
> create a default one without your configuration. Fix it by not
> removing it.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 2da686be33..2ffbcde323 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -751,7 +751,7 @@ clean:
> if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
> rm -f $$d/qemu-options.def; \
> done
> - rm -f $(SUBDIR_DEVICES_MAK) config-all-devices.mak
> + rm -f config-all-devices.mak
>
> VERSION ?= $(shell cat VERSION)
This feels wrong to me. If 'make' is creating config-devices.mak, then
either 'make clean' or 'make distclean' must remove it. So if you remove
it here, it should be added to distclean instead.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH 00/25] Don't "check" disabled drivers, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 04/25] check: Only test vmxnet3 when it is compiled in, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 03/25] check: Use land/lor when possible, Juan Quintela, 2018/07/17
- [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files, Juan Quintela, 2018/07/17
- Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files,
Daniel P . Berrangé <=
- Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files, Juan Quintela, 2018/07/17
- Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files, Peter Maydell, 2018/07/17
- Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files, Juan Quintela, 2018/07/17
- Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files, Peter Maydell, 2018/07/17
- Re: [Qemu-devel] [PATCH 01/25] configure: We don't want to clean configuration files, Juan Quintela, 2018/07/17
[Qemu-devel] [PATCH 02/25] config: CONFIG_SERIAL* is already in pci.mak, Juan Quintela, 2018/07/17
[Qemu-devel] [PATCH 05/25] check: Only test ne2000 when it is compiled in, Juan Quintela, 2018/07/17
[Qemu-devel] [PATCH 06/25] check: Only test eepro100 when it is compiled in, Juan Quintela, 2018/07/17