Re: [Qemu-devel] [PATCH 21/25] check: Only test usb-ohci when it is compiled in

[Thomas Huth]

On 17.07.2018 13:33, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  tests/Makefile.include | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index ccf71bddcc..3a78ada070 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -280,8 +280,8 @@ check-qtest-i386-$(CONFIG_I82801B11) += 
> tests/i82801b11-test$(EXESUF)
>  gcov-files-i386-$(CONFIG_I82801B11) += hw/pci-bridge/i82801b11.c
>  check-qtest-i386-$(CONFIG_IOH3420) += tests/ioh3420-test$(EXESUF)
>  gcov-files-i386-$(CONFIG_IOH3420) += hw/pci-bridge/ioh3420.c
> -check-qtest-i386-y += tests/usb-hcd-ohci-test$(EXESUF)
> -gcov-files-i386-y += hw/usb/hcd-ohci.c
> +check-qtest-i386-$(CONFIG_USB_OHCI) += tests/usb-hcd-ohci-test$(EXESUF)
> +gcov-files-i386-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
>  check-qtest-i386-y += tests/usb-hcd-uhci-test$(EXESUF)
>  gcov-files-i386-y += hw/usb/hcd-uhci.c
>  check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF)
> @@ -343,8 +343,8 @@ check-qtest-ppc64-y += tests/pnv-xscom-test$(EXESUF)
>  check-qtest-ppc64-y += tests/migration-test$(EXESUF)
>  check-qtest-ppc64-y += tests/rtas-test$(EXESUF)
>  check-qtest-ppc64-$(CONFIG_SLIRP) += tests/pxe-test$(EXESUF)
> -check-qtest-ppc64-y += tests/usb-hcd-ohci-test$(EXESUF)
> -gcov-files-ppc64-y += hw/usb/hcd-ohci.c
> +check-qtest-ppc64-$(CONFIG_USB_OHCI) += tests/usb-hcd-ohci-test$(EXESUF)
> +gcov-files-ppc64-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
>  check-qtest-ppc64-y += tests/usb-hcd-uhci-test$(EXESUF)
>  gcov-files-ppc64-y += hw/usb/hcd-uhci.c
>  check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)

Reviewed-by: Thomas Huth <address@hidden>