[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] docker: Use the host architecture
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] docker: Use the host architecture |
Date: |
Tue, 17 Jul 2018 15:45:04 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> This image is badly named and not amd64 specific.
>
> Use `dpkg --print-architecture` to get the host architecture.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
It's like you've been reading my mind ;-)
Reviewed-by: Alex Bennée <address@hidden>
> ---
> tests/docker/dockerfiles/debian-amd64.docker | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker
> b/tests/docker/dockerfiles/debian-amd64.docker
> index eb13f06ed1..3312374304 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -30,9 +30,11 @@ RUN cd /usr/src/virglrenderer && ./autogen.sh &&
> ./configure --with-glx --disabl
> # netmap
> RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> apt-get install -y --no-install-recommends \
> - linux-headers-amd64
> + linux-headers-$(dpkg --print-architecture)
> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
> -RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps
> --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install
> +RUN cd /usr/src/netmap/LINUX && \
> + ./configure --no-drivers --no-apps --kernel-dir=$(ls -d
> /usr/src/linux-headers-*-$(dpkg --print-architecture)) && \
> + make install
> ENV QEMU_CONFIGURE_OPTS --enable-netmap
>
> # gcrypt
--
Alex Bennée
- [Qemu-devel] [PATCH 0/4] docker: Improve 'host-cross' image, Philippe Mathieu-Daudé, 2018/07/16
- [Qemu-devel] [PATCH 1/4] docker: Use the host architecture, Philippe Mathieu-Daudé, 2018/07/16
- Re: [Qemu-devel] [PATCH 1/4] docker: Use the host architecture,
Alex Bennée <=
- [Qemu-devel] [PATCH 2/4] docker: Improve how the virgl library is built, Philippe Mathieu-Daudé, 2018/07/16
- [Qemu-devel] [RFC PATCH 3/4] docker: Rename 'amd64' image as 'host-cross', Philippe Mathieu-Daudé, 2018/07/16
- [Qemu-devel] [RFC PATCH 4/4] docker: Add many libraries to the 'host-cross' image, Philippe Mathieu-Daudé, 2018/07/16
- Re: [Qemu-devel] [PATCH 0/4] docker: Improve 'host-cross' image, Cornelia Huck, 2018/07/17