[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [RFC 06/15] s390-bios: Clean up cio.h
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [RFC 06/15] s390-bios: Clean up cio.h |
Date: |
Tue, 17 Jul 2018 20:15:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 05.07.2018 19:25, Jason J. Herne wrote:
> From: "Jason J. Herne" <address@hidden>
>
> Add proper typedefs to all structs and modify all bit fields to use consistent
> formatting.
>
> Signed-off-by: Jason J. Herne <address@hidden>
> Reviewed-by: Collin Walling <address@hidden>
> Signed-off-by: Jason J. Herne <address@hidden>
> ---
> pc-bios/s390-ccw/cio.h | 86
> ++++++++++++++++++++++-----------------------
> pc-bios/s390-ccw/s390-ccw.h | 8 -----
> 2 files changed, 43 insertions(+), 51 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
> index 1a0795f..a48eee5 100644
> --- a/pc-bios/s390-ccw/cio.h
> +++ b/pc-bios/s390-ccw/cio.h
> @@ -53,12 +53,12 @@ struct schib_config {
> __u64 mba;
> __u32 intparm;
> __u16 mbi;
> - __u32 isc:3;
> - __u32 ena:1;
> - __u32 mme:2;
> - __u32 mp:1;
> - __u32 csense:1;
> - __u32 mbfc:1;
> + __u32 isc : 3;
> + __u32 ena : 1;
> + __u32 mme : 2;
> + __u32 mp : 1;
> + __u32 csense : 1;
> + __u32 mbfc : 1;
checkpatch.pl does not like these spaces, so I think it would be better
to not make these changes (otherwise we'll have to deal with the output
of checkpatch each time again we want to change something here).
Thomas