[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] spice/qlx: atomic-alignment error with clang-7
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] spice/qlx: atomic-alignment error with clang-7 |
|
Date: |
Wed, 18 Jul 2018 17:12:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 18/07/2018 16:56, Philippe Mathieu-Daudé wrote:
> Using clang-7 (Debian) on x86_64 to build v3.0.0-rc1.
>
> Not a regression, it was probably always there:
>
> $ ./configure --cc=clang-7 && make hw/display/qxl.o
> hw/display/qxl.c:1884:19: error: misaligned or large atomic operation
> may incur significant performance penalty [-Werror,-Watomic-alignment]
> old_pending = atomic_fetch_or(&d->ram->int_pending, le_events);
> ^
> include/qemu/atomic.h:206:34: note: expanded from macro 'atomic_fetch_or'
> #define atomic_fetch_or(ptr, n) __atomic_fetch_or(ptr, n, __ATOMIC_SEQ_CST)
> ^
> 1 error generated.
Hi, this is fixed in the latest SPICE git. The upstream commit is
https://gitlab.freedesktop.org/spice/spice-protocol/commit/beda5ec7a6848be20c0cac2a9a8ef2a41e8069c1
Thanks,
Paolo